Simplify FileVisitor and dedup property hook param dependencies#647
Merged
Conversation
Readability refactor with one behavioral fix: - Remove handlePropertyHookNode: the traverser already visits hook params as Node\Param, so the dedicated handler registered every set hook param dependency twice. The existing hook param test now asserts the exact dependency list to lock this in. - Merge the four copy-paste expression handlers (new, static call, class const fetch, instanceof) into handleClassReferenceExpression. - Collapse leaveNode's four identical branches into one ClassLike check. - Fold the anonymous class branch into handleClassNode and inline the addParamDependency indirection. - Group enterNode handlers by intent (declarations, type declarations, expressions, attributes/docblocks). No dependency detection behavior changes other than the dedup. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VUHWv3r1BJyZj4H1WzM3v9
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #647 +/- ##
============================================
- Coverage 98.25% 98.22% -0.04%
+ Complexity 704 689 -15
============================================
Files 87 87
Lines 2008 1968 -40
============================================
- Hits 1973 1933 -40
Misses 35 35
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readability refactor with one behavioral fix:
No dependency detection behavior changes other than the dedup.
Claude-Session: https://claude.ai/code/session_01VUHWv3r1BJyZj4H1WzM3v9