Detect typed class constant dependencies (PHP 8.3)#646
Merged
Conversation
FileVisitor had no handler reading the type of a Node\Stmt\ClassConst, so the class referenced by a typed constant (const MyClass FOO = null) was never registered as a dependency. Add a handler that reuses the shared type-flattening helper, covering nullable and union constant types as well. Fixes #643 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VUHWv3r1BJyZj4H1WzM3v9
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #646 +/- ##
=========================================
Coverage 98.25% 98.25%
- Complexity 701 704 +3
=========================================
Files 87 87
Lines 2001 2008 +7
=========================================
+ Hits 1966 1973 +7
Misses 35 35
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileVisitor had no handler reading the type of a Node\Stmt\ClassConst, so the class referenced by a typed constant (const MyClass FOO = null) was never registered as a dependency. Add a handler that reuses the shared type-flattening helper, covering nullable and union constant types as well.
Fixes #643
Claude-Session: https://claude.ai/code/session_01VUHWv3r1BJyZj4H1WzM3v9