perf: make all static extensions use TSRMG_STATIC (+~10% tokenizer performance in phpstan)#22277
Open
henderkes wants to merge 3 commits into
Open
perf: make all static extensions use TSRMG_STATIC (+~10% tokenizer performance in phpstan)#22277henderkes wants to merge 3 commits into
henderkes wants to merge 3 commits into
Conversation
Contributor
|
just a side-note from a PHPStan maintainer: we really love that someone is looking into php-src which results in faster PHPStan executions. thank you! :-) is the walltime really in |
Contributor
Author
Most definitely not, I'll update the table. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
idea from shivammathur/homebrew-php#5161 (comment)
refs #22231 (comment)
phpstan ran on laravel codebase, aarch64-linux-gnu cloud machine:
affects x86_64 by ~11% on a smaller phpstan run:
The performance change in phpstan comes from tokenizer previously not getting the definition. in order to prevent other extensions from accidentally forgetting to define it, just do it for all of them