Skip to content

fix(engine): retain completed pay-life amount - #7304

Merged
matthewevans merged 3 commits into
mainfrom
ship/fix-engine-retain-completed-pay-life-amount
Aug 12, 2026
Merged

fix(engine): retain completed pay-life amount#7304
matthewevans merged 3 commits into
mainfrom
ship/fix-engine-retain-completed-pay-life-amount

Conversation

@matthewevans

Copy link
Copy Markdown
Member

Fixes #6956.

Preserves the distinction between a completed zero-life cost and a cost with no life-payment component across cost-payment continuations.

@matthewevans
matthewevans enabled auto-merge August 12, 2026 15:35
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@matthewevans, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 5 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 64796a30-830f-484e-b993-fdccbdce545b

📥 Commits

Reviewing files that changed from the base of the PR and between d38f364 and 8163fa6.

📒 Files selected for processing (5)
  • crates/engine/src/game/costs.rs
  • crates/engine/src/game/effects/mod.rs
  • crates/engine/src/game/effects/pay.rs
  • crates/engine/src/game/engine.rs
  • crates/engine/src/types/ability.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@matthewevans
matthewevans force-pushed the ship/fix-engine-retain-completed-pay-life-amount branch from 9d9ec8f to 515efdb Compare August 12, 2026 15:53
@matthewevans
matthewevans disabled auto-merge August 12, 2026 15:56
@matthewevans
matthewevans enabled auto-merge August 12, 2026 15:56
@matthewevans
matthewevans force-pushed the ship/fix-engine-retain-completed-pay-life-amount branch from 515efdb to 8163fa6 Compare August 12, 2026 16:09
@github-actions

github-actions Bot commented Aug 12, 2026

Copy link
Copy Markdown

Generated for head 8163fa68ce98165404a134a58bf684b1e28d8da9.

Parse changes introduced by this PR

✓ No card-parse changes detected.

@matthewevans
matthewevans added this pull request to the merge queue Aug 12, 2026
Merged via the queue into main with commit dc3a57a Aug 12, 2026
15 checks passed
@matthewevans
matthewevans deleted the ship/fix-engine-retain-completed-pay-life-amount branch August 12, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Effects producing a genuine zero leave a stale last_effect_amount, so a chained "that many" reads the previous step

1 participant