CI: minimum supported PyTorch check - #35
Open
pggPL wants to merge 15 commits into
Open
Conversation
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
… 8.9 Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
…1 needs c10::optional Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
…Make Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
… c10::Stream caster Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
…nd lacks c10::Stream caster" This reverts commit 04b4b0f. Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
…torch 2.1 needs c10::optional" This reverts commit 061834f. Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
pggPL
changed the title
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
pggPL
changed the title
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
…ild min-torch job on sm90 Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
… import Signed-off-by: Pawel Gadzinski <pgadzinski@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a workflow verifying that TE builds and imports against
torch==2.8.0:torch==2.8.0pinned,NVTE_CUDA_ARCHS=70, Volta) to keep the build small,tests/pytorch/test_sanity_import.py.Also fixes a real build bug found along the way: the torch extension enabled
NVTE_WITH_NCCL_EPregardless of target archs, while the common library skips NCCL EP when no arch >= 90 is present — an archs<90-only build would fail (missing SymmetricMemory header on older torch, undefinednvte_ep_*otherwise). The extension now uses the samenccl_ep_enabled()gate.(History note: the branch originally targeted torch 2.1, which does NOT compile —
std::optionalvsc10::optionalin generator APIs, noc10::Streampybind caster, FSDP2_fully_shardimports. Those experiments were reverted; see commits.)🤖 Generated with Claude Code