Skip to content

docs: add product-name attributes to prevent naming drift#5113

Open
DeepDiver1975 wants to merge 1 commit into
masterfrom
rebrand-product-name-attribute
Open

docs: add product-name attributes to prevent naming drift#5113
DeepDiver1975 wants to merge 1 commit into
masterfrom
rebrand-product-name-attribute

Conversation

@DeepDiver1975

Copy link
Copy Markdown
Member

Phase 4 of the "ownCloud Classic" rebrand (#5111) — the drift-prevention follow-up.

Adds canonical product-name attributes to global-attributes.yml so the legacy and next-generation product names have a single source of truth, loaded into every build via the existing load-global-site-attributes extension:

attribute value
oc-classic-name ownCloud Classic
oc-ocis-name ownCloud Infinite Scale
oc-ocis-name-short oCIS

Scope: introduces the attributes only. The literal-string rename across the docs (Tier A) and code repos (Tier B) is already complete and merged; substituting these attributes into the existing .adoc occurrences is a separate, later stage. The attributes are inert until referenced, so this change is risk-free.

Verification:

  • global-attributes.yml parses with the project’s js-yaml.
  • A full npx antora site.yml build completes (exit 0, public/ site generated) with no new errors — the only build errors are pre-existing "image not found" warnings in remote docs-ocis content, unrelated to this change.

Closes the last open item in #5111.

Introduce canonical product-name attributes in global-attributes.yml so
the legacy and next-generation product names have a single source of
truth, loaded into every build via the existing
load-global-site-attributes extension:

  oc-classic-name:     ownCloud Classic
  oc-ocis-name:        ownCloud Infinite Scale
  oc-ocis-name-short:  oCIS

This is Phase 4 of the "ownCloud Classic" rebrand (#5111).
The literal-string replacement across the docs (Tier A) and the code
repos (Tier B) is already complete and merged; this attribute is the
drift-prevention follow-up. Substituting these attributes into the
existing .adoc occurrences is a separate, later stage and is not part of
this change - the attributes are inert until referenced.

Verified: global-attributes.yml parses with the project js-yaml, and a
full `antora site.yml` build completes (exit 0, site generated) with no
new errors - the only build errors are pre-existing "image not found"
warnings in remote docs-ocis content, unrelated to this change.

Part of the cross-repo rebrand tracked in #5111.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Signed-off-by: Thomas Müller <1005065+DeepDiver1975@users.noreply.github.com>
@DeepDiver1975

Copy link
Copy Markdown
Member Author

🤖 Automated PR review by Claude Code review agent.

Overview — Phase 4 of the "ownCloud Classic" rebrand (#5111): adds three canonical product-name attributes (oc-classic-name, oc-ocis-name, oc-ocis-name-short) to global-attributes.yml as a single source of truth, loaded via the existing load-global-site-attributes extension.

Assessment — clean, low-risk, no reservations:

  • global-attributes.yml parses correctly (validated with js-yaml/PyYAML); the new keys sit alongside the existing common attributes.
  • The attributes are inert until referenced, so introducing them cannot change any rendered output — the literal-string substitution across .adoc is correctly deferred to a later stage.
  • Documentation + lint CI checks pass; PR is MERGEABLE.
  • Comment accurately documents intent (legacy = "ownCloud Classic"; next-gen = "ownCloud Infinite Scale"/"oCIS", never renamed).
  • owncloud/docs maintains no changelog (no changelog/ dir, no CHANGELOG.md) → no changelog entry required.

No requested changes. (Auto-merge is not applicable: this PR is authored by the agent's own account, which GitHub prevents self-approving — it needs a human reviewer to land.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant