fix: broken stdin during ory dev release publish#445
Conversation
|
Warning Review limit reached
Next review available in: 22 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What was happening
For a non-pre release, pkg.GitTagRelease ran git tag vX.Y.Z -a and handed the process's stdin to git, which spawned vim (cmd/pkg/git.go:46-48). Handing the inherited terminal to a full-screen editor mid-run is fragile: when vim exits, it restores the termios state it saw at startup, and if anything in the session had left the terminal non-canonical, every later stdin read returns EOF. The next thing ory does after the tag is Confirm("Pressing [y] will push…"), whose ReadString got that EOF → pkg.Check printed "An unexpected error occurred: EOF" and exited, leaving the terminal in the raw state (that's the "buggered terminal"; reset or stty sane recovers it). I reproduced the full flow — including your tag.gpgsign=true SSH signing — under a pseudo-terminal where it happens to work, so the corruption is triggered by something specific to your live terminal session, but the editor handoff is the fragile link either way.
The fix (in cmd/pkg/git.go)