Skip to content

OU-1240: Makefile and package.json to enable test-frontend-ci#1091

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
etmurasaki:etmura-test-frontend-ci
Jul 24, 2026
Merged

OU-1240: Makefile and package.json to enable test-frontend-ci#1091
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
etmurasaki:etmura-test-frontend-ci

Conversation

@etmurasaki

@etmurasaki etmurasaki commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Tests
    • Added a CI-specific frontend unit test command.
    • Limited parallel test workers during CI runs to improve execution reliability.
    • Added a convenient Make target for running the CI test suite.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 23, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 23, 2026

Copy link
Copy Markdown

@etmurasaki: This pull request references OU-1240 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from PeterYurkovich and zhuje July 23, 2026 18:04
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2026
@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 75e7dec2-8c0b-4123-9cd3-23b119c81b10

📥 Commits

Reviewing files that changed from the base of the PR and between c4175bb and 3287097.

📒 Files selected for processing (2)
  • Makefile
  • web/package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • web/package.json

Walkthrough

Adds a CI-specific frontend Jest script limited to two workers and a corresponding Makefile target that runs it from the web directory.

Changes

Frontend CI tests

Layer / File(s) Summary
CI test command wiring
web/package.json, Makefile
Adds test:unit:ci with Jest concurrency limited to two workers and exposes it through the test-frontend-unit Make target.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: zhuje, peteryurkovich

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title matches the main change: adding CI-oriented frontend test support in Makefile and package.json.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only changes Makefile and web/package.json; no Ginkgo test titles were added or modified.
Test Structure And Quality ✅ Passed PR only adds a Makefile target and npm script; no Ginkgo test files or assertions were changed.
Microshift Test Compatibility ✅ Passed No new Ginkgo e2e tests were added; changes only add a Makefile target and a Jest CI script, so there’s nothing MicroShift-specific to flag.
Single Node Openshift (Sno) Test Compatibility ✅ Passed Patch only adds Makefile/package.json CI scripts; no new Ginkgo e2e tests or SNO-sensitive cluster assumptions were introduced.
Topology-Aware Scheduling Compatibility ✅ Passed Diff only adds frontend test targets/scripts in Makefile and web/package.json; no manifests, controllers, or scheduling constraints were changed.
Ote Binary Stdout Contract ✅ Passed PR only adds a Makefile target and npm CI test script; no process-level binary stdout behavior was changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The PR only adds a Makefile target and npm script for frontend unit tests; no new Ginkgo e2e tests, IPv4 assumptions, or external connectivity were added.
No-Weak-Crypto ✅ Passed Diff only adds a Makefile target and an npm test script; no crypto APIs, weak algorithms, or secret comparisons appear.
Container-Privileges ✅ Passed PR only adds test targets in Makefile and package.json; no container/K8s manifest changes or privileged/hostPID/hostNetwork/allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed Only adds a CI test target and npm script; no logging, secrets, PII, hostnames, or customer data were introduced.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@etmurasaki

Copy link
Copy Markdown
Contributor Author

/label qe-approved

@openshift-ci openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Jul 23, 2026
@etmurasaki

Copy link
Copy Markdown
Contributor Author

/cherry-pick release-coo-ocp-4.22

@openshift-cherrypick-robot

Copy link
Copy Markdown

@etmurasaki: once the present PR merges, I will cherry-pick it on top of release-coo-ocp-4.22 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-coo-ocp-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Comment thread Makefile Outdated
@etmurasaki
etmurasaki force-pushed the etmura-test-frontend-ci branch from c4175bb to 3287097 Compare July 23, 2026 18:59
@PeterYurkovich

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2026
@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: etmurasaki, PeterYurkovich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [PeterYurkovich,etmurasaki]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PeterYurkovich

Copy link
Copy Markdown
Contributor

/retest

@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

@etmurasaki: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 9fbf9a6 into openshift:main Jul 24, 2026
9 of 10 checks passed
@openshift-cherrypick-robot

Copy link
Copy Markdown

@etmurasaki: new pull request created: #1092

Details

In response to this:

/cherry-pick release-coo-ocp-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@etmurasaki

Copy link
Copy Markdown
Contributor Author

/cherry-pick release-4.22

@openshift-cherrypick-robot

Copy link
Copy Markdown

@etmurasaki: new pull request created: #1094

Details

In response to this:

/cherry-pick release-4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@etmurasaki

Copy link
Copy Markdown
Contributor Author

/cherry-pick release-4.23

@openshift-cherrypick-robot

Copy link
Copy Markdown

@etmurasaki: new pull request created: #1098

Details

In response to this:

/cherry-pick release-4.23

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants