Skip to content

OCPBUGS-99027: Fix CVE-2026-49978 - bump DOMPurify to >= 3.4.7#1087

Open
germanparente wants to merge 1 commit into
openshift:release-4.20from
germanparente:fix-CVE-2026-49978-release-4.20
Open

OCPBUGS-99027: Fix CVE-2026-49978 - bump DOMPurify to >= 3.4.7#1087
germanparente wants to merge 1 commit into
openshift:release-4.20from
germanparente:fix-CVE-2026-49978-release-4.20

Conversation

@germanparente

Copy link
Copy Markdown
Contributor

What this PR does / why we need it

CVE-2026-49978: DOMPurify IN_PLACE sanitization bypass via attached Shadow Root inside <template>.content (XSS). Affects DOMPurify versions <= 3.4.6.

monitoring-plugin has DOMPurify 3.3.0 as a transitive dependency via monaco-editor. This adds a dompurify override in package.json to bump it to ^3.4.11 (resolved to 3.4.12).

Which issue(s) this PR fixes

OCPBUGS-99027

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Add dompurify override to bump transitive dependency from 3.3.0 to
^3.4.11, fixing DOMPurify IN_PLACE sanitization bypass via attached
Shadow Root inside <template>.content (XSS).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 23, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@germanparente: This pull request references Jira Issue OCPBUGS-99027, which is invalid:

  • expected dependent Jira Issue OCPBUGS-99028 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it

CVE-2026-49978: DOMPurify IN_PLACE sanitization bypass via attached Shadow Root inside <template>.content (XSS). Affects DOMPurify versions <= 3.4.6.

monitoring-plugin has DOMPurify 3.3.0 as a transitive dependency via monaco-editor. This adds a dompurify override in package.json to bump it to ^3.4.11 (resolved to 3.4.12).

Which issue(s) this PR fixes

OCPBUGS-99027

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 23, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b5de6637-e5d0-4cab-97b8-fc9ff426857e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from jgbernalp and zhuje July 23, 2026 15:05
@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

@germanparente: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jgbernalp

Copy link
Copy Markdown
Contributor

/label qe-approved

@jgbernalp

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Jul 23, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 23, 2026
@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: germanparente, jgbernalp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants