Skip to content

NO-JIRA: Fix make build target cd issue#1404

Open
jrangelramos wants to merge 1 commit into
openshift:mainfrom
jrangelramos:fix-make-build
Open

NO-JIRA: Fix make build target cd issue#1404
jrangelramos wants to merge 1 commit into
openshift:mainfrom
jrangelramos:fix-make-build

Conversation

@jrangelramos

@jrangelramos jrangelramos commented Jun 11, 2026

Copy link
Copy Markdown
Member

Fix make build target error

$ make build       
hack/build-go.sh
hack/build-go.sh: line 6: cd: null directory
make: *** [Makefile:5: build] Error 1

Summary by CodeRabbit

  • Chores
    • Minor build script improvements to ensure proper repository directory navigation.

Fix make build target error `./hack/build-go.sh: line 6: cd: null
directory`
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Walkthrough

The build script hack/build-go.sh has been modified to append ./ to the repository root path computed by git rev-parse --show-cdup during the directory change operation.

Changes

Build Script Repository Navigation

Layer / File(s) Summary
Repository root navigation fix
hack/build-go.sh
The cd command now appends ./ to the path from git rev-parse --show-cdup for repository root navigation.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR #1404 changes only hack/build-go.sh (cd path fix). No Ginkgo It/Describe/Context/When titles are added or modified, so no nondeterministic test names are introduced.
Test Structure And Quality ✅ Passed PR #1404 changes only hack/build-go.sh (cd path). No Ginkgo test files/code were modified, so the Ginkgo quality requirements are not applicable here.
Microshift Test Compatibility ✅ Passed PR #1404 changes only hack/build-go.sh (cd "$(git rev-parse --show-cdup)./"); no new/modified Ginkgo e2e tests to evaluate for MicroShift compatibility.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR #1404 changes only hack/build-go.sh (1 file); no new/modified Ginkgo e2e tests are introduced, so SNO compatibility assumptions can’t be implicated.
Topology-Aware Scheduling Compatibility ✅ Passed PR changes hack/build-go.sh only: it just tweaks repo-root cd (cd "$(git rev-parse --show-cdup)./"); no manifests/controllers/scheduling constraints added.
Ote Binary Stdout Contract ✅ Passed PR changes only hack/build-go.sh (cd path fix); OTE binary main (cmd/cluster-version-operator-tests/main.go) has no fmt.Print/Println/Printf/log/klog stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR #1404 changes only hack/build-go.sh (cd "$(git rev-parse --show-cdup)./"); no new/modified Ginkgo e2e tests, so no IPv6/disconnected networking assumptions to flag.
No-Weak-Crypto ✅ Passed PR changes only hack/build-go.sh; scanning that file shows no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB or non-constant-time secret/token comparisons.
Container-Privileges ✅ Passed Only hack/build-go.sh changed (git diff origin/main..HEAD --name-only lists 1 file); no container/K8s manifests or privilege settings (hostPID/hostNetwork/allowPrivilegeEscalation/etc.) were modified.
No-Sensitive-Data-In-Logs ✅ Passed PR 1404 only updates the cd command in hack/build-go.sh; it does not add any logging that would expose passwords/tokens/API keys/PII/internal hostnames.
Title check ✅ Passed The title accurately reflects the build target cd fix made in hack/build-go.sh.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jrangelramos

Copy link
Copy Markdown
Member Author

/retest

@jhadvig jhadvig left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2026
@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidHurta, jhadvig, jrangelramos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2026
@DavidHurta

Copy link
Copy Markdown
Contributor

/retitle NO-JIRA: Fix make build target cd issue

@openshift-ci openshift-ci Bot changed the title Fix make build target cd issue NO-JIRA: Fix make build target cd issue Jul 3, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 3, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@jrangelramos: This pull request explicitly references no jira issue.

Details

In response to this:

Fix make build target error

$ make build       
hack/build-go.sh
hack/build-go.sh: line 6: cd: null directory
make: *** [Makefile:5: build] Error 1

Summary by CodeRabbit

  • Chores
  • Minor build script improvements to ensure proper repository directory navigation.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@DavidHurta

Copy link
Copy Markdown
Contributor

/verified by ci/prow/images, @DavidHurta

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 3, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@DavidHurta: This PR has been marked as verified by ci/prow/images,@DavidHurta.

Details

In response to this:

/verified by ci/prow/images, @DavidHurta

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@DavidHurta

Copy link
Copy Markdown
Contributor

Thanks, @jrangelramos!

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD a3b1280 and 2 for PR HEAD 0907045 in total

@openshift-ci

openshift-ci Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

@jrangelramos: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn 0907045 link true /test e2e-agnostic-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants