Skip to content

Re-get the protocol in the eventually loop, otherwise it keeps the sa… #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinaeyNL merged 1 commit into from
Aug 12, 2026
Merged

Re-get the protocol in the eventually loop, otherwise it keeps the sa… #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions .../src/test/groovy/org/openremote/extension/entsoe/agent/protocol/EntsoeProtocolTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -463,10 +463,11 @@ class EntsoeProtocolTest extends Specification implements ManagerContainerTrait
asset = assetStorageService.merge(asset)

def attributeRef = new AttributeRef(asset.id, "energyPrice")
def protocol = (EntsoeProtocol) agentService.getProtocolInstance(agent.id)
def protocol = null

then: "the protocol is connected and attribute linked"
conditions.eventually {
protocol = (EntsoeProtocol) agentService.getProtocolInstance(agent.id)
assert protocol != null
assert agentService.getAgent(agent.id).getAgentStatus().orElse(null) == ConnectionStatus.CONNECTED
assert protocol.getLinkedAttributes().containsKey(attributeRef)
Expand Down Expand Up @@ -943,10 +944,11 @@ class EntsoeProtocolTest extends Specification implements ManagerContainerTrait
asset = assetStorageService.merge(asset)

def attributeRef = new AttributeRef(asset.id, "energyPrice")
def protocol = (EntsoeProtocol) agentService.getProtocolInstance(agent.id)
def protocol = null

then: "the protocol is connected and attribute linked"
conditions.eventually {
protocol = (EntsoeProtocol) agentService.getProtocolInstance(agent.id)
assert protocol != null
assert agentService.getAgent(agent.id).getAgentStatus().orElse(null) == ConnectionStatus.CONNECTED
assert protocol.getLinkedAttributes().containsKey(attributeRef)
Expand Down Expand Up @@ -1021,10 +1023,11 @@ class EntsoeProtocolTest extends Specification implements ManagerContainerTrait
asset = assetStorageService.merge(asset)

def attributeRef = new AttributeRef(asset.id, "energyPrice")
def protocol = (EntsoeProtocol) agentService.getProtocolInstance(agent.id)
def protocol = null

then: "the protocol is connected and attribute linked"
conditions.eventually {
protocol = (EntsoeProtocol) agentService.getProtocolInstance(agent.id)
assert protocol != null
assert agentService.getAgent(agent.id).getAgentStatus().orElse(null) == ConnectionStatus.CONNECTED
assert protocol.getLinkedAttributes().containsKey(attributeRef)
Expand Down