feat: remove legacy Django unit editor - #38985
Conversation
|
Thanks for the pull request, @salman2013! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Update the status of your PRYour PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
The legacy unit editor (controlled by LEGACY_STUDIO_UNIT_EDITOR waffle flag) has been fully removed. The MFE-based unit editor (frontend-app- authoring) is now the only editor and is always active. Removed: - LEGACY_STUDIO_UNIT_EDITOR CourseWaffleFlag - container_handler legacy Django-rendered path (now always redirects to MFE) - xblock_edit_view and xblock_edit_handler URL (/xblock/<key>/action/edit) - container.html and container_editor.html templates - unit_outline_spec.js and related legacy tests Kept (still used by MFE): - container_embed_handler and /container_embed/<key> URL - container_chromeless.html template (rendered for MFE iframes) - use_new_unit_page serializer field (hardcoded True; MFE still reads it) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
717835e to
2d87434
Compare
Summary
LEGACY_STUDIO_UNIT_EDITORwaffle flag and all code paths behind it — the MFE-based unit editor (frontend-app-authoring) is now always activecontainer.html(legacy full-page unit editor) andcontainer_editor.html(legacy xblock edit modal) templatesxblock_edit_viewfunction and its URL pattern (/xblock/<key>/action/edit)container_handlerto always redirect to the MFEWhat was kept (MFE still needs these)
container_embed_handlerand/container_embed/<usage_key>URL — used by the MFE to load xblock content in iframescontainer_chromeless.htmltemplate — rendered for those MFE iframesuse_new_unit_pageserializer field — hardcodedTrue; MFE still reads it from the waffle flags APIFuture cleanup (tracked in dev memory)
use_new_unit_pagefrom API): removeuse_new_unit_page()fromtoggles.pyand the serializer field/methodcontainer_embed_handlerand its entire JS/template stackReferences:
#2539
#35587
#36495
Test plan
container_embed_handleriframes)pytest cms/djangoapps/contentstore/ --ds=cms.envs.test🤖 Generated with Claude Code