Skip to content

fix: display agregate values for scope and organization in tables rows - #201

Closed
dcoa wants to merge 2 commits into
openedx:masterfrom
eduNEXT:dcoa/agg-scope-org-name
Closed

fix: display agregate values for scope and organization in tables rows#201
dcoa wants to merge 2 commits into
openedx:masterfrom
eduNEXT:dcoa/agg-scope-org-name

Conversation

@dcoa

@dcoa dcoa commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Description

The API supports aggregated scopes and organizations, which makes the table difficult to read. This PR consolidates the strings used throughout the wizard into module-level constants so they can be reused when indicating platform-wide or organization-wide scope. This also helps maintain consistent terminology and tone across the module.

Before

Organization displays a wildcard and scope the wildcards for platform or organization

image

After

image

How to test

  1. Open the admin console with a superadmin user.
  2. Assign platform or organization scopes using the wizard.
  3. See in the table the new rows with the "All organizations",All <courses/libraries> on/in <scope>

Additional information

#156

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Aug 5, 2026
@openedx-webhooks

openedx-webhooks commented Aug 5, 2026

Copy link
Copy Markdown

Thanks for the pull request, @dcoa!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.66%. Comparing base (c08e45d) to head (b2926d9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #201      +/-   ##
==========================================
+ Coverage   97.64%   97.66%   +0.01%     
==========================================
  Files          68       68              
  Lines        1702     1715      +13     
  Branches      447      411      -36     
==========================================
+ Hits         1662     1675      +13     
  Misses         40       40              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dcoa
dcoa marked this pull request as ready for review August 5, 2026 08:13
@dcoa dcoa added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Aug 5, 2026
@dcoa dcoa linked an issue Aug 5, 2026 that may be closed by this pull request
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Aug 5, 2026

@jacobo-dominguez-wgu jacobo-dominguez-wgu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dcoa

dcoa commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

Taking this product decision in consideration #156 (comment) I will proceed to close the PR.

Thank you all.

@dcoa dcoa closed this Aug 7, 2026
@github-project-automation github-project-automation Bot moved this from Waiting on Author to Done in Contributions Aug 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). create-sandbox open-craft-grove should create a sandbox environment from this PR open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Improvement] Show the global info message instead of *

4 participants