Stop uploading the same screenshot twice

[andiwand]

1.41's screenshots went up doubled twice. The log says why, and it is not what #177 guessed.

Not one upload failed. All 132 pictures were sent and accepted. What failed is deliver's second pass: it reads the set back from App Store Connect and re-sends anything it cannot find. The store lists a picture a few seconds after it takes it, so what deliver cannot find is only the locales it sent last - sv and tr, at the end of the alphabet, in both apps, in both runs.

The second copy then joins the first, fills the locale to the ten screenshots a set allows, and the rest are dropped:

tr/ipad-01-browser.png is missing on App Store Connect.     <- it was not
Failed to upload all screenshots... Tries remaining: 4
Too many screenshots found for device 'APP_IPAD_PRO_3GEN_129' in 'tr',
  skipping this one (tr/ipad-05-pdf.png)                    <- dropped
[..]: Successfully uploaded all screenshots                 <- green

So the locale ends up doubled and short, and the job passes.

Stop sending a second copy

The Fastfile patches Deliver::UploadScreenshots#retry_upload_screenshots_if_needed to wait and look again - six times, thirty seconds apart, asking the store fresh each time - and to fail loudly if a picture is still missing after that. It never sends a second copy.

Exercised against the real deliver 2.237.0:

store lists them	outcome	re-uploaded
first look	returns, no wait	no
third look	returns after two waits	no
never	fails the job after three minutes	no

The listing check from #177 stays as a backstop, in case a fastlane upgrade moves what is patched, and now also catches Too many screenshots found, which is how the dropped pictures were silent.

Repair without photographing anything again

A release can now be started with screenshots_from_run set to an earlier run's id. Only the two listing jobs run, against that run's framed artifact. Nothing is built, photographed, uploaded or tagged, no build number is spent, and it takes about five minutes instead of forty.

Since the lane clears each locale before it uploads, that repairs a set however it got broken. It is how 1.41's screenshots get fixed: merge this, then dispatch with version 1.41 and screenshots_from_run 32182462133.

Not the beta sync flag

deliver's sync_screenshots was considered. It diffs local against remote instead of clearing first, which sounds like the right shape, but it computes local - remote from the same freshly-fetched listing and so carries the identical race. Its comparison key is locale/filename/checksum with no position, so Array#- deletes both copies of a duplicate before re-uploading one - it converges, but through a pass where the locale is empty. It is beta, gated behind FASTLANE_ENABLE_BETA_DELIVER_SYNC_SCREENSHOTS, and announces it may break. Not worth it when the plain path is deterministic once the retry is gone.

🤖 Generated with Claude Code

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0db3a9d77d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".