Take odrcore 6.9.0 - #605
Merged
Merged
Conversation
The engine moves from 6.8.0 to 6.9.0, and nothing here has to move with it. No file type, extension or mime type changes, so `SupportedDocumentTypes` derives the same two sets and `STRICT_CATCH`'s generated intent-filters still match them, which `SupportedFormatsTest` confirms. The only binding change is subtractive: `HtmlConfig.embedOutline`, `noDrm`, `backgroundImageFormat` and `backgroundImageDpi` are deprecated and inert. `CoreLoader` sets none of the four - it names `embedImages`, `embedShippedResources`, `relativeResourcePaths`, `textDocumentMargin`, `editable` and `colorScheme` - so there is nothing to unset and no new API to take up. What 6.9.0 brings arrives in the rendering, for free. That rendering is pdf and docx. A filled-in form now shows what was filled in and a marked-up pdf its markup, both painted from the annotation's own appearance stream; hidden, no-view and popup annotations stay off the page. A scanned page decodes rather than coming out blank, `JBIG2Decode` in house - MMR/Huffman, refinement and halftone regions still skip the image. Justified text is spaced as the file asks, a page is turned as its `/Rotate` says, a subset font naming its glyphs `gidNNNNN` reads correctly, and a Flate stream that omits its ADLER32 trailer opens instead of failing. A `.docx` is spaced the way word spaces it - paragraph spacing before and after, line height, the contextual spacing that keeps a list tight, and table row heights as a minimum - and a table follows the paragraph and text properties its `w:tblStyle` names. Drafted ahead of the release: 6.9.0 is not on maven central yet, so the only unresolved dependency in the tree is this one and CI cannot go green until the core's release run publishes the AAR. Everything else resolves. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HKv3uQhxEhwBTvyAXXagoV
andiwand
marked this pull request as ready for review
August 18, 2026 19:55
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c0b778cd1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine moves from 6.8.0 to 6.9.0, and nothing here has to move with it. No file
type, extension or mime type changes, so
SupportedDocumentTypesderives the same twosets and
STRICT_CATCH's generated intent-filters still match them, whichSupportedFormatsTestconfirms.The only binding change is subtractive:
HtmlConfig.embedOutline,noDrm,backgroundImageFormatandbackgroundImageDpiare deprecated and inert.CoreLoadersets none of the four - it names
embedImages,embedShippedResources,relativeResourcePaths,textDocumentMargin,editableandcolorScheme- so there isnothing to unset and no new API to take up. What 6.9.0 brings arrives in the rendering,
for free.
That rendering is pdf and docx. A filled-in form now shows what was filled in and a
marked-up pdf its markup, both painted from the annotation's own appearance stream;
hidden, no-view and popup annotations stay off the page. A scanned page decodes rather
than coming out blank,
JBIG2Decodein house - MMR/Huffman, refinement and halftoneregions still skip the image. Justified text is spaced as the file asks, a page is turned
as its
/Rotatesays, a subset font naming its glyphsgidNNNNNreads correctly, and aFlate stream that omits its ADLER32 trailer opens instead of failing.
A
.docxis spaced the way word spaces it - paragraph spacing before and after, lineheight, the contextual spacing that keeps a list tight, and table row heights as a
minimum - and a table follows the paragraph and text properties its
w:tblStylenames.Drafted ahead of the release
6.9.0 is the version cliff will cut - three
feat:commits since v6.8.0, nothingbreaking - but it is not on maven central yet.
:app:dependenciesresolves the wholetree with exactly one failure, this one, so CI cannot go green until the core's release
run publishes the AAR. Mark it ready then; if the cut lands on a different number, the
one line in
gradle/libs.versions.tomlis the whole change.🤖 Generated with Claude Code