Let the listing go up when the pictures did not

[andiwand]

The listing job named screenshot-set in a plain needs:, which means a
screenshot run that wedged an emulator did not cost the release its pictures -
it skipped the job outright and cost the release its store copy and this
version's release notes as well. The bundle went up, record tagged the
commit and drafted the release, and the one job that tells Play what the release
says never ran. Green run, half a release.

The Fastfile was already written for the other outcome and never reached:

captured = !Dir.glob(File.join(FRAMED_DIR, "*", "*.png")).empty?
unless captured
  UI.important("no screenshots under #{FRAMED_DIR} - writing the listing text only")
  return false
end

with skip_upload_screenshots: !captured handing supply the answer, so the
store keeps the pictures it already has.

What changes

screenshot-set supplies the job rather than gating it.

• if: ${{ !cancelled() && !inputs.dry_run && needs.upload.result == 'success' }}.
  !cancelled() is what takes the implicit success() off the needs:;
  needs.upload.result puts back the half that does have to hold, since a
  listing names a version code and there is no version code until the bundle is
  up.
• The screenshot download runs only when there is a set to download. The
  artifact is written with if-no-files-found: error, so a screenshot-set
  that passed is the same answer as one that exists.
• A ::warning:: when there are none, because the alternative is a release
  finishing green over a listing still showing an earlier version's pictures.

Nothing else moves: the release stays coupled to the screenshots, and the hour
they take is still on its critical path.

How it was checked

On a throwaway branch rather than by reading the docs, since a needs: behaving
other than assumed is the whole of this bug. Three jobs of the same shape, run
both ways round:

	upload	screenshot-set	listing
pictures fail	success	failure	runs - fetch skipped, warning written, needs.screenshot-set.result reads failure
bundle fails	failure	success	skipped, as before

actionlint is clean, and it does resolve the hyphenated needs.screenshot-set

• a deliberate typo there is an error, so its silence means something.

What is still unproven is the same thing as before: no release has yet run these
jobs for real.

🤖 Generated with Claude Code

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c8724a34dd

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".