Hold the two large text bugs a reader reported - #597
Merged
Conversation
andiwand
force-pushed
the
test/large-text-regressions
branch
from
August 18, 2026 07:04
c559116 to
707ced5
Compare
andiwand
marked this pull request as ready for review
August 18, 2026 07:14
Both fail against odrcore 6.7.1 and pass once the fixes for them are taken:
took 29150ms, over the 15000ms budget
expected:<text/[plain]> but was:<text/[csv]>
They are end to end on purpose. The engine's own tests cover the detection
rule and the layout it does; what neither can say is that a megabyte of text
opens in this app and can then be searched.
The file is generated rather than checked in - a megabyte of filler is not
worth a git object, and nothing here depends on which words it is.
Do not merge before the odrcore bump.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01TouAQNfktsp9THcceennEX
andiwand
force-pushed
the
test/large-text-regressions
branch
from
August 18, 2026 08:21
707ced5 to
6d5036a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From user feedback: "Funktioniert seit Neuestem nicht mehr brauchbar mit größeren TXT Files (ca. 1 MB): File laden dauert lange, ebenso die unmögliche Textstellensuche! War vorher prima."
Two tests, one per bug. Against the shipped odrcore 6.7.1 they fail with exactly the reported symptoms:
Both go green once the app takes an odrcore carrying:
Why here and not only in the engine
Both engine PRs carry their own tests. What neither can say is that a megabyte of text opens in this app and is then searchable — the loader, the cache, the WebView and Find are all on this side of the boundary.
aMegabyteOfTextOpensAndIsSearchableasserts the search finds every line and that opening plus searching fits in a budget;proseWithCommasStaysTextasserts the mime type the app ends up showing.The budget is 15s against a measured 0.26s for layout after the fix, so it is a ceiling a broken render cannot fit under rather than a benchmark.
The text file is generated rather than checked in — a megabyte of filler is not worth a git object, and nothing here depends on which words it is.
🤖 Generated with Claude Code