test(html): read a few files in a second config - #699
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e8f0e0c5f4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The reference output renders every file in one config, so a toggle the config does not set is covered nowhere: nothing rendered dark, and the margins we turn on here hid the reflowed text document the library ships by default. A test file may now carry a `ConfigVariant` — a named deviation applied last — and is rendered once more into a sibling directory suffixed with the name. The pdf text mode was the one case of this and becomes the first row of the table, keeping its path. Added: `dark` for one file per view that carries a dark stylesheet (document, slides, spreadsheet, text, filesystem, font), `system` for the media-query wrapper around it, `reflow` for a text document kept out of its page box, and `read-only` for the output a reader gets. The pdf view honors no color scheme, and no test file reaches the image view at all. The reference resources were a few pull requests behind — document.css missed the 3mm inset and the dark stylesheets, text.js the batched line-number sizing — and are regenerated with this. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EPasn1P1Y4xGehbRdWWFwY
andiwand
force-pushed
the
test/html-output-config-variants
branch
from
August 18, 2026 13:49
e8f0e0c to
515d775
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reference output renders every file in one config, so a toggle that config does not set is covered nowhere. Nothing renders dark, and the page margins we turn on here hide the reflowed text document the library actually ships by default — the 3mm inset added in #698 appears in no reference file at all.
The mechanism
A test file may now carry a
ConfigVariant— a name plus a deviation applied last to the config — and is rendered a second time into a sibling directory suffixed with that name.pdf_text_modewas the one hand-rolled case of this and becomes the first row of the table, keeping its-singlepath byte for byte.The suffix keeps every output directory at the same depth, so the link to the shared
resources/is identical in the variant and in the default.What is covered now
singlepdf_text_mode = single_layerdarkcolor_scheme = darksystemcolor_scheme = systemreflowtext_document_margin = falseread-onlyeditable = falseDark mode is pinned per view, not per format —
document,spreadsheet,text,filesystemandfonteach carry their own dark stylesheet. The pdf view honors no color scheme (FileTypeCapabilities::color_schemesays so), and no test file reaches the image view at all, so that one stays uncovered.Verified
Every pre-existing reference file is byte-identical after the change — the refactor moves nothing. Each new output was inspected in a browser: dark renders dark and readable in all five views,
systemdiffers fromdarkonly bymedia="(prefers-color-scheme: dark)",reflowdrops the page box and picks up.odr-text-flow{padding:3mm}, andread-onlydropscontenteditableanddata-odr-path.Reference output
The shipped resources were a few pull requests behind:
document.cssmissed the 3mm inset and the dark stylesheets,text.jsthe batched line-number sizing from #696. Regenerated with this, so the pins move for those too.🤖 Generated with Claude Code