Correct the Workers Builds branch control note - #16
Open
patshone-gsl wants to merge 1 commit into
Open
Conversation
Workers Builds has no per-branch exclusion list, only an all-or-nothing checkbox for non-production branches. Earlier guidance in this file described a capability that does not exist. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BUGFIX
Documentation-only. Earlier guidance in
MIGRATION-NOTES.mdand PR #13 said to excludedocumentation,3.9andrelease/*from Workers Builds triggers. That capability does not exist, so the note would have sent the next person looking for a setting that isn't there.Docs
Jira - none. Documentation correction; branch named descriptively.
Solution overview
Root cause
Workers Builds branch control (Overview → Worker → Settings → Build → Branch control) offers only a production-branch dropdown and a single all-or-nothing checkbox for non-production branches. There is no per-branch include or exclude list.
Fix
Records what the setting actually offers, that non-production builds are currently enabled — evidenced by two feature-branch pushes each producing a
versions uploadwith no deployment — and that thedocumentationproblem is therefore live rather than hypothetical.Also records that there is no clean mitigation: the build fails at
npm cibefore any command we control runs, and apackage.jsoncannot be added todocumentationbecause GitBook owns that branch.Recommendation captured: disable non-production branch builds, on alarm-fatigue grounds rather than noise — a real failure on
mainwould be lost among constantdocumentationfailures. Preview URLs are convenient for the Phase 4 look-and-feel review but not required, sincescripts/screenshots.mjsworks against a local dev server.Breaking changes
None. Documentation only.