Conversation
…aths The retrieve helpers returned early (NULL result or pending secondary exception) without releasing their local references. As giws embeds the JVM, local references are only freed when the thread detaches, so they accumulated. Also store the inline GetObjectClass(javaException) result so it can be released on every path.
…urn-size-array booleanDataGiws emitted 'int *lenRow;' followed by '*lenRow = GetArrayLength(res)': a write through an uninitialized pointer. Align it with the base class dataGiws which declares a local 'int lenRow' value when the size is not returned through an output parameter.
The generated classes have a virtual method (getCurrentEnv), so deleting an instance was flagged by -Wdelete-non-virtual-dtor and deleting a derived wrapper through a base pointer was undefined behavior.
Unused variables (example3, bug_disable_return, bug_no_param_int_array, inherit/showcase), variable-length arrays in example2 (a Clang extension in C++) and catching the polymorphic JniException by value in example3. Everything now builds with -Wall -Werror with both gcc and clang.
…Werror After 'make examples' has generated the wrappers, compile every example .cpp (generated and hand-written) with g++ -Wall -Werror -fsyntax-only.
The 3.1.0 release was never published (the local tag will be replaced): with the generated-code behavior changes accumulated since 3.0.1 (virtual destructor, exception checks on non-static methods, ABI-visible fixes), this is a major version.
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.