fix(runtime): support reviewed scan approval defaults - #441
fix(runtime): support reviewed scan approval defaults#441mldangelo-oai wants to merge 4 commits into
Conversation
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5e4497300c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Security review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
Summary
Run security scans in managed Codex environments that require automatic approval review while preserving an explicit deny-all mode.
Changes
approval_policy="never", including in the selected profile, in the shared credential home, persisted runtime, saved scan recipe, and actual SDK-created scan thread.Testing
bun test --timeout 30000 --only-failures tests-ts/api-preflight-config.test.ts tests-ts/api.test.ts tests-ts/cli-workbench.test.ts tests-ts/config.test.ts— 175 passed, 0 failed.bun test --timeout 30000 --only-failures --randomize --seed 12345 ./tests-ts— 1,141 passed, 11 skipped, 0 failed.pnpm run typespnpm run formatpnpm exec prettier --check ../../SECURITY.mdpnpm run buildapproval_policy="never".Risk and rollout
This intentionally changes default scan approvals from deny-all to Codex automatic review. The baseline filesystem profile remains unchanged, but an approved request can grant additional permissions for its specific operation. Set
--codex 'approval_policy="never"'or use a selected profile with strict denial when required. Existing saved scans without an approval policy continue to deny all requests when rerun. Standalone validation, patching, and finding-comparison commands retain their existing approval behavior.Public disclosure review