Skip to content

[Fix #1553] Initialize call field in generated Callxxx classes #1555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjtirado merged 1 commit into from
Jul 22, 2026
+12 −3
Merged

[Fix #1553] Initialize call field in generated Callxxx classes #1555

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions api/src/test/java/io/serverlessworkflow/api/FeaturesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
*/
package io.serverlessworkflow.api;

import static io.serverlessworkflow.api.WorkflowReader.readWorkflow;
import static io.serverlessworkflow.api.WorkflowReader.readWorkflowFromClasspath;
import static io.serverlessworkflow.api.WorkflowReader.validation;
import static io.serverlessworkflow.api.WorkflowWriter.workflowAsBytes;
Expand All @@ -30,9 +29,13 @@
import java.io.IOException;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.ValueSource;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

public class FeaturesTest {

private static final Logger logger = LoggerFactory.getLogger(FeaturesTest.class);

@ParameterizedTest
@ValueSource(
strings = {
Expand Down Expand Up @@ -71,8 +74,11 @@ private static Workflow writeAndReadInMemory(Workflow workflow) throws IOExcepti
writeWorkflow(out, workflow, WorkflowFormat.JSON);
bytes = out.toByteArray();
}
if (logger.isDebugEnabled()) {
logger.debug("Workflow string representation is {}", new String(bytes));
}
try (ByteArrayInputStream in = new ByteArrayInputStream(bytes)) {
return readWorkflow(in, WorkflowFormat.JSON);
return validation().read(in, WorkflowFormat.JSON);
}
}

Expand Down
5 changes: 4 additions & 1 deletion generators/types/src/main/java/io/serverlessworkflow/generator/CustomAnnotator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@

import com.fasterxml.jackson.databind.JsonNode;
import com.sun.codemodel.JDefinedClass;
import com.sun.codemodel.JExpr;
import com.sun.codemodel.JFieldVar;
import io.serverlessworkflow.annotations.AdditionalProperties;
import jakarta.validation.constraints.Pattern;
Expand All @@ -40,7 +41,9 @@ public void additionalPropertiesField(JFieldVar field, JDefinedClass clazz, Stri
public void propertyField(
JFieldVar field, JDefinedClass clazz, String propertyName, JsonNode propertyNode) {
if (propertyNode.has(CONST)) {
field.annotate(Pattern.class).param("regexp", propertyNode.get(CONST).asText());
String callValue = propertyNode.get(CONST).asText();
field.annotate(Pattern.class).param("regexp", callValue);
field.init(JExpr.lit(callValue));
}
}
}
Loading