docs(config): publish declarative config spec conformance matrix#5347
Open
MikeGoldsmith wants to merge 3 commits into
Open
docs(config): publish declarative config spec conformance matrix#5347MikeGoldsmith wants to merge 3 commits into
MikeGoldsmith wants to merge 3 commits into
Conversation
Contributor
|
Does adding it here not work? |
Contributor
@MikeGoldsmith I wonder what is the motivation for this PR, is the compliance matrix in the spec not detailed enough? In any case, having this new matrix here is harmless but I understand the point of @herin049 above, I am also curious. |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There is no published view of which fields of the OpenTelemetry declarative configuration schema the Python SDK currently applies. That makes it hard to define "most use cases covered" for a 1.0 recommendation, to communicate gaps to users and vendors, and to compare coverage against Go, Java, and JS.
This PR adds the matrix:
opentelemetry-sdk/src/opentelemetry/sdk/_configuration/spec-conformance.mdlisting every schema section (resource, propagator, tracer/meter/logger providers, attribute_limits, OTLP exporter properties, sampler, id_generator, configurators, exemplar filter, views) with a tri-state status (✅ Supported /Mirrors the equivalent JS doc landed in open-telemetry/opentelemetry-js#6846 (tracked via open-telemetry/opentelemetry-js#6809).
Fixes #5346. Part of #3631.
Type of change
How Has This Been Tested?
opentelemetry-sdk/src/opentelemetry/sdk/_configuration/_*.pyand the regeneratedmodels.py, not just the schema.log_level,attribute_limits,instrumentation/development,distribution, configurators, log-record limits, Prometheus secondary flags, Viewattribute_keys.excluded,jaeger_remotesampler,otlp_fileexporters).Does This PR Require a Contrib Repo Change?
Checklist: