opentelemetry-sdk: add log record limits environment variables#5300
Open
herin049 wants to merge 5 commits into
Open
opentelemetry-sdk: add log record limits environment variables#5300herin049 wants to merge 5 commits into
herin049 wants to merge 5 commits into
Conversation
ocelotl
reviewed
Jun 24, 2026
|
|
||
| self.max_log_record_attributes = self._from_env_if_absent( | ||
| max_log_record_attributes, | ||
| OTEL_LOGRECORD_ATTRIBUTE_COUNT_LIMIT, |
Contributor
There was a problem hiding this comment.
If this environment variable exists and is set to "", then self.max_log_record_attributes would be set to None, but the spec says this should be 128. Should this be 128 in the situation described before?
Contributor
Author
There was a problem hiding this comment.
The default should only apply if you don't have the environment variable set at all (which is the current behavior). If you set OTEL_LOGRECORD_ATTRIBUTE_COUNT_LIMIT="" then I think the assumption is that the limit should effectively be infinite. This is the current behavior of all of the attribute limits from what I can tell.
ocelotl
reviewed
Jun 24, 2026
ocelotl
left a comment
Contributor
There was a problem hiding this comment.
Left a question regarding possible default values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the
OTEL_LOGRECORD_ATTRIBUTE_COUNT_LIMITandOTEL_LOGRECORD_ATTRIBUTE_VALUE_LENGTH_LIMITenvironment variables. (see Spec Compliance Matrix)Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: