Conversation
|
Of course, the sooner we get rid of apple pay express, we can point the gem its' origin and not need to worry about being behind. Let's see what the analysis results in. |
|
@severin It does apply though was already covered by me when first porting the gem: https://github.com/onrunning/adyen-ruby-api-library/blob/develop/lib/adyen/client.rb#L41 . The change makes the for the checkoutUtility and checkout similar to each other, with the combined condition that's already covered. |
|
I was making the PR draft until making sure that the production environment won't be broken by this change. I made sure of this following these steps:
config = Spree::Gateway::AdyenApi.find_by(environment: 'production').preferences
client = ::AdyenAPI::Client.new(api_key: config.fetch(:api_key), env: config.fetch(:environment).to_sym, live_url_prefix: config.fetch(:live_url_prefix))
client.checkout_utility.origin_keys(originDomains: ['https://www.on-running.com']).body # => "{\"originKeys\":{\"https:\\/\\/www.on-running.com\":\"pub.v2.2615010577511341.aHR0cHM6Ly93d3cub24tcnVubmluZy5jb20.ak15kZVmruFTUF4d3k_jUglcQXYgZnVGYS1KNpI5qVU\"}}" |
|
@severin thanks for the quick feedback :) . I'll merge it and open a pr in the main app. |
|
yet another reason to get rid of current apple pay express |
For testing:
gem 'adyen-ruby-api-library', github: 'onrunning/adyen-ruby-api-library', branch: 'develop', ref: '95a3f45'