TDT-2791 Clarify event visibility default is Google-only#754
Conversation
The Visibility JSDoc allowed 'default' for all providers without noting that Microsoft and EWS accounts reject it with a 400 error. Only Google events support 'default'. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #754 +/- ##
=======================================
Coverage 98.75% 98.75%
=======================================
Files 43 43
Lines 1041 1041
Branches 90 90
=======================================
Hits 1028 1028
Misses 12 12
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AaronDDM
left a comment
There was a problem hiding this comment.
Good afternoon! Thanks for tightening this up — the note is accurate and the provider-specific 400 behaviour is worth calling out. One thing before this ships: there's no entry under the Unreleased section in CHANGELOG.md. Please add a short line under Changed (e.g. "Clarify that event default visibility is Google-only") so the doc fix is tracked. Docs themselves look good.
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
What
Updates the JSDoc for the
Visibilitytype insrc/models/events.tsto note thatdefaultonly works for Google events. Microsoft and EWS accounts return a 400 error whendefaultis sent, but the type declaration didn't warn about this.Jira: TDT-2791 (sub-task of TDT-2765)
🤖 Generated with Claude Code