node: add option to use self signed certs - #4114
Merged
Merged
Conversation
End-rey
requested review from
carpawell,
cthulhu-rider and
roman-khimov
as code owners
July 31, 2026 16:11
End-rey
marked this pull request as draft
July 31, 2026 16:11
End-rey
force-pushed
the
mtls-internode-dont-sign-requests
branch
6 times, most recently
from
August 13, 2026 11:49
65478c2 to
8c62845
Compare
End-rey
force-pushed
the
mtls-internode-dont-sign-requests
branch
2 times, most recently
from
August 14, 2026 13:20
4fe9284 to
4227c45
Compare
End-rey
force-pushed
the
self-signed-internode-cert
branch
from
August 17, 2026 10:25
bc07116 to
5eec53c
Compare
Contributor
Author
|
I think #4131 should go first. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4114 +/- ##
==========================================
+ Coverage 27.15% 27.21% +0.06%
==========================================
Files 679 679
Lines 46203 46303 +100
==========================================
+ Hits 12548 12603 +55
- Misses 32466 32507 +41
- Partials 1189 1193 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
End-rey
force-pushed
the
self-signed-internode-cert
branch
from
August 18, 2026 14:28
5eec53c to
ef7db45
Compare
End-rey
marked this pull request as ready for review
August 18, 2026 14:28
Generate a TLS certificate from the node key for TLS gRPC endpoints without `grpc.tls.certificate`. Use the generated certificate for inter-node client authentication and validate self-signed candidate certificates against the public key announced in the network map. Closes #4090. Signed-off-by: Andrey Butusov <andrey@nspcc.io>
End-rey
force-pushed
the
self-signed-internode-cert
branch
from
August 19, 2026 09:27
ef7db45 to
23b9825
Compare
roman-khimov
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4090.