csv: drop x/text dependency - #71
Open
roman-khimov wants to merge 1 commit into
Open
Conversation
This code was added in 205b818, back then the original LOCODE DB was used. Then a6b65a7 changed our source to Github repo that contains pure UTF-8 data and handles cp1252->utf8 in scripts preparing the data. This makes the code redundant and we can drop x/text dependency by removing it. Signed-off-by: Roman Khimov <roman@nspcc.ru>
roman-khimov
requested review from
End-rey,
carpawell and
cthulhu-rider
as code owners
August 24, 2026 18:33
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 30.45% 31.01% +0.56%
==========================================
Files 20 20
Lines 660 648 -12
==========================================
Hits 201 201
+ Misses 459 447 -12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code was added in 205b818, back then the original LOCODE DB was used. Then a6b65a7 changed our source to Github repo that contains pure UTF-8 data and handles cp1252->utf8 in scripts preparing the data. This makes the code redundant and we can drop x/text dependency by removing it.