fix(eventsource): handle empty event fields#5584
Open
Ram-blip wants to merge 1 commit into
Open
Conversation
Signed-off-by: Ram-blip <ramcruze2000@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
This PR corrects EventSource behavior when an empty
eventfield follows a previously specified custom event type in the same Server-Sent Events block.Rationale
The Server-Sent Events specification requires every recognized
eventfield to replace the current event-type buffer, including when the field value is empty.For example:
The second
eventfield has an empty value, so it should clear the previouscustomevent type. The payload should then be dispatched using the defaultmessageevent type.Undici previously ignored empty
eventfield values. As a result, the earliercustomvalue remained in the event-type buffer, and the payload was incorrectly dispatched to thecustomlistener instead of the defaultmessagelistener.Changes
Features
N/A
Bug Fixes
eventfield values instead of ignoring them.eventfield.messageevent type when the event-type buffer is empty.eventfield.EventSourceregression test verifying that the payload is delivered to themessagelistener.Breaking Changes and Deprecations
None.
This change only corrects the previous non-conformant listener-routing behavior for valid SSE blocks containing a nonempty
eventfield followed by an empty one.Status