fixt(nextcloud): extract db environment#864
Merged
Merged
Conversation
Signed-off-by: WrenIX <dev.github@wrenix.eu>
DreamingRaven
approved these changes
Jun 26, 2026
Collaborator
There was a problem hiding this comment.
LGTM assuming the new substitution works. My validation checks pass with kubeconform, and nothing that I can see that should be breaking.
The README could probably use regenerating since you changed the values.yaml but its so minor in this case I dont think it matters much either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
extract db environment variables for easier reuse
Benefits
easier reuse e.g. for notify_push later or with
extraManifestsPossible drawbacks
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver.