refactor(pinia): move attachmentStore to pinia#8142
Open
grnd-alt wants to merge 1 commit into
Open
Conversation
grnd-alt
force-pushed
the
refactor/pinia-migration-attachment-attachmentStore
branch
from
e2f51d9 to
0c18fc1
Compare
Signed-off-by: grnd-alt <git@belakkaf.net>
grnd-alt
force-pushed
the
refactor/pinia-migration-attachment-attachmentStore
branch
from
0c18fc1 to
944683c
Compare
github-project-automation
Bot
moved this to 🧭 Planning evaluation (don't pick)
in 📝 Productivity team
grnd-alt
moved this from 🧭 Planning evaluation (don't pick)
to 👀 In review
in 📝 Productivity team
samin-z
reviewed
Jul 9, 2026
| } else { | ||
| this.attachments[cardId].push(attachment) | ||
| } | ||
| this.$vuex.commit('cardSetAttachmentCount', { cardId }) |
Contributor
There was a problem hiding this comment.
based on what i found, 'cardSetAttachmentCount' expects two variables but only one is passed. should'nt this not be used?
| if (existingIndex !== -1) { | ||
| Vue.set(this.attachments[attachment.cardId][existingIndex], 'deletedAt', Date.now() / 1000 | 0) | ||
| } | ||
| this.$vuex.commit('cardDecreaseAttachmentCount', { cardId: attachment.cardId }) |
Contributor
There was a problem hiding this comment.
wouldnt sending 'cardId' break it?
this is what is expected:
cardDecreaseAttachmentCount(1)
and not
cardDecreaseAttachmentCount(cardId: 1) {
Contributor
|
Functionality check finds:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.