Skip to content

[NAE-2462] Builder component decomposition - #469

Open
Kovy95 wants to merge 2 commits into
release/6.6.0from
NAE-2462
Open

[NAE-2462] Builder component decomposition#469
Kovy95 wants to merge 2 commits into
release/6.6.0from
NAE-2462

Conversation

@Kovy95

@Kovy95 Kovy95 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Description

  • add processref field

Implements NAE-2462

Dependencies

none

Third party dependencies

  • No new dependencies were introduced

Blocking Pull requests

There are no dependencies on other PR

How Has Been This Tested?

  • manually

Test Configuration

<Please describe configuration for tests to run if applicable, like program parameters, host OS, VM configuration etc.>

Name Tested on
OS linux mint 21
Runtime java 21
Dependency Manager maven 3.9.9
Framework version Spring boot 3.4.4
Run parameters
Other configuration

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes have been checked, personally or remotely, with @...
  • I have commented my code, particularly in hard-to-understand areas
  • I have resolved all conflicts with the target branch of the PR
  • I have updated and synced my code with the target branch
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes:
    • Lint test
    • Unit tests
    • Integration tests
  • I have checked my contribution with code analysis tools:
  • I have made corresponding changes to the documentation:
    • Developer documentation
    • User Guides
    • Migration Guides

Summary by CodeRabbit

  • New Features
    • Added support for process reference fields, allowing forms and datasets to store lists of linked process references.
    • Process reference fields now support default values, clearing, and duplication while preserving their configured values.
    • Added import support for process reference field types.
    • Process references are serialized consistently as processRef for data exchange.

@Kovy95 Kovy95 self-assigned this Aug 3, 2026
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

Walkthrough

The change adds the PROCESS_REF field type, introduces the ProcessField domain class, and updates FieldFactory to construct process reference fields with configured defaults.

Changes

Process reference fields

Layer / File(s) Summary
Process reference field domain model
src/main/groovy/com/netgrif/application/engine/petrinet/domain/dataset/FieldType.groovy, src/main/groovy/com/netgrif/application/engine/petrinet/domain/dataset/ProcessField.groovy
Adds the processRef field type and a MongoDB-mapped ProcessField for List<String> values.
Process field importer integration
src/main/java/com/netgrif/application/engine/importer/service/FieldFactory.java
Adds PROCESS_REF construction, applies configured defaults, and removes the unused Importer argument from string collection construction.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title describes builder decomposition, but the changes add and handle the PROCESS_REF field type. Rename the title to identify the primary change, such as "NAE-2462 Add PROCESS_REF field support".
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@src/main/groovy/com/netgrif/application/engine/petrinet/domain/dataset/FieldType.groovy`:
- Line 21: Update FieldType.fromString to match serialized getName() values such
as “caseRef” and “processRef” rather than relying only on uppercased enum names;
normalize the input consistently so all `@JsonValue` camelCase names resolve. Add
a round-trip test covering each FieldType’s getName() output and parsing it back
to the same enum.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 64fed39f-0fec-4dbb-95bc-8b20eee8fb9e

📥 Commits

Reviewing files that changed from the base of the PR and between 03f4e73 and 2609d36.

📒 Files selected for processing (3)
  • src/main/groovy/com/netgrif/application/engine/petrinet/domain/dataset/FieldType.groovy
  • src/main/groovy/com/netgrif/application/engine/petrinet/domain/dataset/ProcessField.groovy
  • src/main/java/com/netgrif/application/engine/importer/service/FieldFactory.java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant