Part nasa/cFS#1079, Adding specialty PR templates and links to the specialty PR templates in the default PR template. - #113
Part nasa/cFS#1079, Adding specialty PR templates and links to the specialty PR templates in the default PR template.#113dzbaker wants to merge 2 commits into
Conversation
…ecialty PR templates in the default PR template.
| <!-- Required. Reference the GitHub issue this PR addresses, e.g., Closes #123 --> | ||
| Closes # | ||
|
|
||
| ## Areas of Expertise Touched |
There was a problem hiding this comment.
A link to the expertise Excel file would be helpful for determining who to contact
|
|
||
| --- | ||
|
|
||
| ## Author Checklist |
There was a problem hiding this comment.
Can we add something like "Commit history squashed"
There was a problem hiding this comment.
Discussed at 8/3/2026 stand up and team decided to place commit squashing guidance in a central "Pull Request Guide," as the commit history should/should not be squashed depending on the circumstances. This is being tracked in nasa/cFE#2788 and the PR templates will be updated accordingly once that guide has been created.
| ## Reviewer Checklist | ||
|
|
||
| - [ ] Code logic is correct and matches the stated intent | ||
| - [ ] Code is readable, maintainable, and follows project conventions |
There was a problem hiding this comment.
Could you link the coding standards here?
| - [ ] Unit tests are meaningful and adequately cover the changes | ||
| - [ ] **The change has been exercised by the unit tests** (not just that tests pass — the new/changed code paths are actually covered) |
| ## Requirements Impact | ||
|
|
||
| <!-- List any requirements impacted by this change. Indicate whether each was updated, or confirm the change continues to satisfy existing requirements. --> | ||
| - Requirement ID(s): |
There was a problem hiding this comment.
A link to the requirements would be helpful
| ### COSMOS Test Suite | ||
| <!-- Link to CI run, paste summary, or note "N/A — no relevant changes" --> | ||
|
|
||
| ## Areas of Expertise Touched |
There was a problem hiding this comment.
A link to the expertise Excel file would be helpful for determining who to contact
|
|
||
| Closes # | ||
|
|
||
| ## Areas of Expertise Touched |
There was a problem hiding this comment.
A link to the expertise Excel file would be helpful for determining who to contact
|
|
||
| --- | ||
|
|
||
| ## Author Checklist |
There was a problem hiding this comment.
Can we add something like "Commit history squashed"
There was a problem hiding this comment.
Discussed at 8/3/2026 stand up and team decided to place commit squashing guidance in a central "Pull Request Guide," as the commit history should/should not be squashed depending on the circumstances. This is being tracked in nasa/cFE#2788 and the PR templates will be updated accordingly once that guide has been created.
|
|
||
| --- | ||
|
|
||
| ## Author Checklist |
There was a problem hiding this comment.
Can we add something like "Commit history squashed"
There was a problem hiding this comment.
Discussed at 8/3/2026 stand up and team decided to place commit squashing guidance in a central "Pull Request Guide," as the commit history should/should not be squashed depending on the circumstances. This is being tracked in nasa/cFE#2788 and the PR templates will be updated accordingly once that guide has been created.
2 participants
name: Comment / Documentation Change
about: Changes limited to comments, README, docstrings, or other documentation
labels: documentation
Description of Change
Linked Issue
Closes #
Areas of Expertise Touched
Author Checklist
Reviewer Checklist