test(mdx-models): raise coverage threshold from 0.21 to 0.80#378
Merged
Conversation
- Added 55 new Groovy Spock test files covering all 67 accessor base classes across every domain (account, transfer, payment, profile, etc.) - Added tests for utility classes: Resources, CharArrayAdapter, ModelWrappableSerializer, AccountType, Frequency, MdxMappingException - Excluded POJO domain model packages from coverage calculation (same pattern used by mdx-gateways for its generated/accessor packages) - Excluded boilerplate exception/error-descriptor classes from coverage - Raised minimumCoverage from 0.21 → 0.80 (actual instruction coverage: 92%)
mattnichols
requested review from
RyanJones08,
gerfboy,
stevecl5 and
tessstoddard
as code owners
gerfboy
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://mxcom.atlassian.net/browse/MC-13289
Summary
domain (account, ach_transfer, authorization, credit_report, cross_account_transfer,
device, document, location, managed_card, origination, p2p_transfer, payment, payout,
products, profile, remote_deposit, transfer)
ModelWrappableSerializer, AccountType, Frequency, MdxMappingException
mdx-gateways uses for its generated/accessor packages)
Test Plan
./gradlew :mdx-models:test— all 569 tests pass./gradlew :mdx-models:jacocoTestCoverageVerification— passes at ≥ 0.80./gradlew :mdx-models:check— full check including Spotless passes