Editor: Fix tiny cursor in the empty editor#4300
Open
ayshushus wants to merge 1 commit into
Open
Conversation
Collaborator
Author
|
I spent a lot of time trying a native fix instead of a CM-drawn approach, this caused me to hard code a |
Collaborator
|
Redirecting to Eemeli, since he knows more about CodeMirror than me. |
Collaborator
Author
Yes. This has caused changes. They are to both the behavioural aspects you mentioned in #4240
|
Member
|
Could you describe the changes this PR makes to the behaviour of the cursor in RTL messages? I don't understand from your previous comment what the changes are, and whether they make the situation better or worse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4249
add
drawSelection()to CM.Test in Nightly.