You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This looks like a useful false-positive fix. One edge case I would keep in mind: metadata often becomes a marketplace-specific namespace, so it is probably best treated as ecosystem info without requiring skillcheck to understand every nested key. A regression where metadata contains both normal links and an unknown nested namespace would help preserve that boundary.
Added the regression suggested here: the fixture now keeps regular metadata links and an unknown nested marketplace namespace under metadata, and the parser test asserts that nested metadata is preserved. Validation: git diff --check; npx --yes markdown-link-check tests/fixtures/metadata_field.md --quiet; uv run --python /Users/burak/.local/bin/python3.11 --with pytest --with pytest-cov --with pyyaml python -m pytest -q -o addopts= tests/test_v1_2_false_positive_fixes.py.
Thanks @kriptoburak, merged! Fixed the README conflict on the way in (set the test count to 833 = main's 832 + your new test). Nice first contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
metadataas an ecosystem-common frontmatter field instead of an unknown field.Validation
git diff --checkpython -m pytest -qnpx --yes markdown-link-check README.md tests/fixtures/metadata_field.md --quiet