refactor: test events phase 2 (@miodec)#8036
Draft
Miodec wants to merge 78 commits into
Draft
Conversation
use new system for current wpm, raw, acc, burst
|
Wow |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 30 out of 30 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
frontend/src/ts/test/replay-ui.ts:55
- deriveReplayActions() infers word submission only from wordIndex changes, so a final word commit (space/newline) with no subsequent input event never emits submitCorrectWord/submitErrorWord. This breaks replay rendering (wordCount) and correctness coloring for the last word. Use the existing input event flag commitsWord to emit submit actions at the commit event time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yeet everything, derive from events.