Skip to content

ci: use ECR instead of Artifactory for Garasign images DEVPROD-34208 - #841

Open
fetsko wants to merge 2 commits into
mongodb-js:mainfrom
fetsko:DEVPROD-34208/use-devprod-platforms-ecr
Open

ci: use ECR instead of Artifactory for Garasign images DEVPROD-34208#841
fetsko wants to merge 2 commits into
mongodb-js:mainfrom
fetsko:DEVPROD-34208/use-devprod-platforms-ecr

Conversation

@fetsko

@fetsko fetsko commented Jul 27, 2026

Copy link
Copy Markdown

Description

This migrates from Artifactory to ECR for pulling the DevProd container images.

Checklist

  • New tests and/or benchmarks are included
  • Documentation is changed or added
  • If this change updates the UI, screenshots/videos are added and a design review is requested
  • If this change could impact the load on the MongoDB cluster, please describe the expected and worst case impact
  • I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)

Motivation and Context

MongoDB Artifactory will be deprecated soon.

  • Bugfix
  • New feature
  • Dependency update
  • Misc

Open Questions

N/A

Dependents

N/A

Types of changes

  • Backport Needed
  • Patch (non-breaking change which fixes an issue)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to change)

Copilot AI review requested due to automatic review settings July 27, 2026 19:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the signing-utils package to stop using Artifactory credentials/registry paths and instead authenticate to AWS ECR and pull Garasign container images from ECR, aligning with the upcoming Artifactory deprecation.

Changes:

  • Replace Artifactory username/password environment variables with an ECR login password in getEnv().
  • Update remote signing to export ecr_login_password to the remote session before invoking garasign.sh.
  • Switch garasign.sh Docker login/logout and image references from Artifactory to ECR.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
packages/signing-utils/src/utils.ts Updates env collection to source ECR_LOGIN_PASSWORD instead of Artifactory credentials.
packages/signing-utils/src/signing-clients/remote-signing-client.ts Updates remote signing command to pass ECR login secret to the remote script.
packages/signing-utils/src/garasign.sh Updates Docker auth and image references to pull Garasign images from ECR instead of Artifactory.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/signing-utils/src/garasign.sh
Comment thread packages/signing-utils/src/signing-clients/remote-signing-client.ts
@fetsko
fetsko marked this pull request as ready for review July 27, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants