ci: use ECR instead of Artifactory for Garasign images DEVPROD-34208 - #841
Open
fetsko wants to merge 2 commits into
Open
ci: use ECR instead of Artifactory for Garasign images DEVPROD-34208#841fetsko wants to merge 2 commits into
fetsko wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the signing-utils package to stop using Artifactory credentials/registry paths and instead authenticate to AWS ECR and pull Garasign container images from ECR, aligning with the upcoming Artifactory deprecation.
Changes:
- Replace Artifactory username/password environment variables with an ECR login password in
getEnv(). - Update remote signing to export
ecr_login_passwordto the remote session before invokinggarasign.sh. - Switch
garasign.shDocker login/logout and image references from Artifactory to ECR.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| packages/signing-utils/src/utils.ts | Updates env collection to source ECR_LOGIN_PASSWORD instead of Artifactory credentials. |
| packages/signing-utils/src/signing-clients/remote-signing-client.ts | Updates remote signing command to pass ECR login secret to the remote script. |
| packages/signing-utils/src/garasign.sh | Updates Docker auth and image references to pull Garasign images from ECR instead of Artifactory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fetsko
marked this pull request as ready for review
July 27, 2026 19:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This migrates from Artifactory to ECR for pulling the DevProd container images.
Checklist
Motivation and Context
MongoDB Artifactory will be deprecated soon.
Open Questions
N/A
Dependents
N/A
Types of changes