Add PACKAGEVERSION token expansion for manifest fields#6312
Open
Trenly wants to merge 2 commits into
Open
Conversation
- Expand <PACKAGEVERSION> in supported manifest fields for YAML and REST parsing - Add/adjust YAML and REST tests and test data coverage - Update release notes with explicit supported fields Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
This PR adds
<PACKAGEVERSION>token expansion for manifest data fields that can include versioned values.Implemented behavior:
<PACKAGEVERSION>at manifest parse time (YAML and REST), distinct from runtime installer argument token replacement like<LOGPATH>.Installers[*].NestedInstallerFiles[*].RelativeFilePathInstallers[*].ProductCodeInstallers[*].AppsAndFeaturesEntries[*].DisplayNameInstallers[*].AppsAndFeaturesEntries[*].ProductCodeInstallers[*].InstallationMetadata.DefaultInstallLocationInstallers[*].InstallationMetadata.Files[*].RelativeFilePathDefaultLocale.ReleaseNotesUrlLocalization[*].ReleaseNotesUrlPACKAGEVERSIONto the spelling allowlist.This PR was prepared with assistance from GitHub Copilot.
🔗 References
Resolves #4494
🔍 Validation
src/AppInstallerCLITests/YamlManifest.cppsrc/AppInstallerCLITests/RestInterface_1_4.cppsrc/AppInstallerCLITests/TestData/Manifest-Good-PackageVersionToken.yamlsrc/AppInstallerCLITests/AppInstallerCLITests.vcxproj✅ Checklist
📋 Issue Type