WIP: start issue #240 implementation for skipped downstream node status#249
Open
Pyrotechnic679 wants to merge 2 commits into
Open
WIP: start issue #240 implementation for skipped downstream node status#249Pyrotechnic679 wants to merge 2 commits into
Pyrotechnic679 wants to merge 2 commits into
Conversation
Author
|
@microsoft-github-policy-service agree |
a33d705 to
8641868
Compare
…tions - Widen df.nodes.nodes_status_chk in the 0.2.3->0.2.4 upgrade script to allow 'skipped', matching the fresh-install DDL in src/lib.rs so upgraded installs also get the new terminal status (without it the runtime no-ops forever). - Use canonical df.await_instance in test 49 (consistent with other e2e tests), fix branch-filter indentation, and add trailing newline.
Contributor
|
Reviewed and pushed a follow-up commit ( What changed
Validation run locally
Still open / discussion
The orchestration change also adds a scheduled activity on the failure path; note this alters recorded history for any orchestration that fails across a binary upgrade (narrow window) — flagging for awareness. |
pinodeca
added a commit
that referenced
this pull request
Jun 23, 2026
Adds docs/node-state-model.md, a design proposal consolidating the node-status work for issues #240 (skipped downstream nodes) and #171 (race-loser nodes left running/pending). Defines instance and node lifecycle states, legal transitions, a coarse status set plus nullable status_reason, loop iteration-scoping/reset semantics, and prior-art alignment with Airflow/Temporal/BPMN/Step Functions. The #240 skipped-node work shipped earlier in PR #249; this PR (#263) defines the consolidated model and will add the remaining implementation (cancelled, status_reason, race-loser reconciliation, loop reset) after review. Design only; implementation to follow on this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is an initial WIP for issue #240.
It starts implementation work to make downstream, unexecuted nodes observable after workflow failure (instead of remaining ambiguous as
pending).Current state
Intent
Opening early to signal active work and allow maintainers to review direction before finalizing implementation details.