Reject scalar Normalizer inputs - #32161
Open
Akshay Sonawane (apsonawane) wants to merge 1 commit into
Open
Conversation
Copilot started reviewing on behalf of
Akshay Sonawane (apsonawane)
August 18, 2026 23:01
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Rejects unsupported rank-0 inputs before normalization.
Changes:
- Adds scalar-input validation.
- Tests all three normalization modes for rejection.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
onnxruntime/core/providers/cpu/ml/normalizer.cc |
Rejects scalar inputs with a clear error. |
onnxruntime/test/providers/cpu/ml/normalizer_test.cc |
Verifies scalar rejection for MAX, L1, and L2. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Akshay Sonawane (apsonawane)
enabled auto-merge (squash)
August 18, 2026 23:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves input validation for the
Normalizeroperator by adding a check to reject scalar (rank-0) inputs and introducing a corresponding unit test to ensure this behavior. The main changes are as follows:Input validation improvements:
normalizer.ccto return an error if the input tensor has rank 0, ensuring only rank 1 or 2 inputs are accepted.Testing enhancements:
normalizer_test.cc(ScalarInputRejected) to verify that scalar inputs are correctly rejected with an appropriate error message.