Harden Crop operator validation - #32157
Open
Edward Chen (edgchen1) wants to merge 2 commits into
Open
Conversation
Reject negative and out-of-range border and scale attributes without overflow. Align DirectML validation, handle empty CUDA outputs, and add provider-wide regression coverage. Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Hardens Crop validation across CPU, CUDA, and DirectML while supporting empty CUDA outputs.
Changes:
- Rejects invalid border and scale values without arithmetic overflow.
- Aligns DirectML validation with shared Crop behavior.
- Adds cross-provider regression tests.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
onnxruntime/contrib_ops/cpu/crop.h |
Adds overflow-safe attribute validation. |
onnxruntime/contrib_ops/cuda/tensor/crop.cc |
Handles empty outputs and checked integer conversions. |
onnxruntime/core/providers/dml/OperatorAuthorHelper/OperatorHelper.cpp |
Adds DirectML bounds and sign validation. |
onnxruntime/test/contrib_ops/crop_op_test.cc |
Expands invalid-input and edge-case coverage. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reject negative and out-of-range border and scale attributes without overflow. Align DirectML validation, handle empty CUDA outputs, and add provider-wide regression coverage.
Motivation and Context
Fix Crop validation issues.