Add 0.8 state-aware configuration adapters - #941
Open
Gudge (MGudgin) wants to merge 1 commit into
Open
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Gudge (MGudgin)
pushed a commit
that referenced
this pull request
Aug 19, 2026
This PR updates the version-specific parser plan with the completed Phase 5D adapter boundary and Phase 7 integration responsibilities. Details * Record Phase 5D completion and PR #941. * Document the development adapter facade and neutral state-aware wire input. * Keep final-model convergence, shared normalization, and diagnostic parity in Phase 7. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1ef43cc5-5752-426e-a36e-eb9aaccfb9ad
This PR adds exhaustive state-aware adapters for the mutable 0.8.0-alpha configuration contract. Details * Map every state-aware lifecycle and provision request into the current wire model. * Preserve validated experimental data and source text in a neutral pre-normalization value. * Destructure contract marker fields by their qualified type pattern rather than discarding them, so widening a marker fails to compile at the adapters that hardcode its wire value. * Add development-request facade coverage plus comprehensive expected-wire and current-wire equivalence tests. Tests * `cargo fmt --all -- --check` * `cargo check -p wxc_common` * `cargo clippy -p wxc_common --all-targets -- -D warnings` * `cargo test -p wxc_common` Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 1ef43cc5-5752-426e-a36e-eb9aaccfb9ad
Gudge (MGudgin)
force-pushed
the
user/gudge/version_specific_config_parsers_phase5d
branch
from
August 19, 2026 03:12
adfc678 to
24b7408
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds exhaustive adapters from the 0.8.0-alpha state-aware contracts into the existing wire model.
Changes:
- Adds adapters for all lifecycle phases and provision backends.
- Preserves raw experimental configuration and source text.
- Adds comprehensive mapping and wire-equivalence tests.
Show a summary per file
| File | Description |
|---|---|
src/core/wxc_common/src/state_aware_wire.rs |
Defines the pre-normalization state-aware representation. |
src/core/wxc_common/src/lib.rs |
Registers the new wire module. |
src/core/wxc_common/src/config_contract_adapters/mod.rs |
Updates adapter staging comments. |
src/core/wxc_common/src/config_contract_adapters/dev/common.rs |
Centralizes shared conversions. |
src/core/wxc_common/src/config_contract_adapters/dev/mod.rs |
Adds the unified development-request adapter. |
src/core/wxc_common/src/config_contract_adapters/dev/one_shot.rs |
Reuses shared conversion helpers. |
src/core/wxc_common/src/config_contract_adapters/dev/state_aware.rs |
Implements state-aware request conversions. |
src/core/wxc_common/src/config_contract_adapters/dev/state_aware_tests/mod.rs |
Registers state-aware test modules. |
src/core/wxc_common/src/config_contract_adapters/dev/state_aware_tests/common.rs |
Tests raw data and source preservation. |
src/core/wxc_common/src/config_contract_adapters/dev/state_aware_tests/provision.rs |
Tests all provision adapters. |
src/core/wxc_common/src/config_contract_adapters/dev/state_aware_tests/start.rs |
Tests start adaptation. |
src/core/wxc_common/src/config_contract_adapters/dev/state_aware_tests/exec.rs |
Tests exec adaptation. |
src/core/wxc_common/src/config_contract_adapters/dev/state_aware_tests/stop.rs |
Tests stop adaptation. |
src/core/wxc_common/src/config_contract_adapters/dev/state_aware_tests/deprovision.rs |
Tests deprovision adaptation. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 14/14 changed files
- Comments generated: 0
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds exhaustive state-aware adapters for the mutable
0.8.0-alphaconfiguration contract.This PR is stacked on #929.
Details
Tests
cargo fmt --all -- --checkcargo check --workspace --all-targetscargo clippy -p wxc_common -p mxc_config_contract --all-targets -- -D warningscargo test -p wxc_common -p mxc_config_contractMicrosoft Reviewers: Open in CodeFlow