[WIP] Fix extract-zip unvalidated symlink path traversal vulnerability - #840
Draft
Gudge (MGudgin) with Copilot wants to merge 2 commits into
Draft
[WIP] Fix extract-zip unvalidated symlink path traversal vulnerability#840Gudge (MGudgin) with Copilot wants to merge 2 commits into
Gudge (MGudgin) with Copilot wants to merge 2 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: MGudgin <26722142+MGudgin@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Review details
Files not reviewed (1)
- tests/playground/package-lock.json: Generated file
Suppressed comments (1)
tests/playground/package.json:97
- The requested Reachability Assessment is missing from the PR description. Please add the required section and confidence level, noting that this path is indirectly reachable during Electron's postinstall (Electron calls the extractor for its downloaded distribution), while the replacement package's documented threat model relies on
@electron/getchecksum validation of that archive.
"electron": "^41.10.3",
- Files reviewed: 1/2 changed files
- Comments generated: 0 new
- Review effort level: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original prompt