Limit model blob downloads to three hours - #1007
Merged
Merged
Conversation
Prevent stalled Azure blob transfers from running indefinitely while preserving explicit callback cancellation. Document the current inference cancellation limits and remove an overbroad C# cancellation claim. Files changed: - README.md - sdk_v2/cpp/src/download/blob_downloader.cc - sdk_v2/cs/README.md Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16cc8b6f-2bc4-4469-bf59-f21439569349
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Avoid an unnecessary source-line break in the short cancellation limitation. Files changed: - README.md Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16cc8b6f-2bc4-4469-bf59-f21439569349
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a three-hour deadline to model blob downloads and clarifies cancellation behavior.
Changes:
- Applies a shared three-hour deadline per blob.
- Distinguishes callback cancellation from timeout failures.
- Updates cancellation documentation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
sdk_v2/cpp/src/download/blob_downloader.cc |
Adds deadline and timeout error mapping. |
sdk_v2/cs/README.md |
Corrects the async API claim. |
README.md |
Documents inference cancellation behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Correct the cancellation documentation to reflect existing Request.Cancel support and the remaining cooperative/no-deadline limitations. Add focused regression coverage for timeout versus explicit-cancellation error classification without expanding production timeout plumbing. Files changed: - README.md - sdk_v2/cpp/test/internal_api/download_test.cc Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16cc8b6f-2bc4-4469-bf59-f21439569349
Keep the release change limited to the production deadline and concise documentation rather than adding test-only timeout machinery. Files changed: - sdk_v2/cpp/test/internal_api/download_test.cc Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 16cc8b6f-2bc4-4469-bf59-f21439569349
Baiju Meswani (baijumeswani)
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Model.Download.OPERATION_CANCELLED; report deadline expiry as a network timeout.CancellationToken.Validation
blob_downloader.ccdirectly with MSVC.git diff --checkpasses.