Skip to content

Fix #63427: Add type definition for Math.sumPrecise (ES2025)#63550

Closed
tanushbhootra576 wants to merge 2 commits into
microsoft:mainfrom
tanushbhootra576:fix/math-sum-precise
Closed

Fix #63427: Add type definition for Math.sumPrecise (ES2025)#63550
tanushbhootra576 wants to merge 2 commits into
microsoft:mainfrom
tanushbhootra576:fix/math-sum-precise

Conversation

@tanushbhootra576

Copy link
Copy Markdown

Fixes #63427

Description:
Adds the type definition for Math.sumPrecise to esnext.core.d.ts in accordance with the ES2025 Stage 4 TC39 proposal. Registered the library in libs.json and referenced it in esnext.d.ts.

Specification Reference:
https://github.com/tc39/proposal-math-sum

Checklist:

  • Added types strictly match the TC39 proposal.
  • Ran hereby runtests-parallel and updated test snapshots via hereby baseline-accept.
  • Verified code formatting with hereby lint.

Note: AI assistance was used to format the documentation structure and verify the type signature against the ECMA-262 proposal.

Copilot AI review requested due to automatic review settings June 12, 2026 13:03
@github-project-automation github-project-automation Bot moved this to Not started in PR Backlog Jun 12, 2026
@typescript-automation typescript-automation Bot added the For Backlog Bug PRs that fix a backlog bug label Jun 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Adds a new esnext.core lib definition and wires it into the esnext umbrella lib / default libs list, but the current test baseline indicates the compiler still can’t resolve the new lib.

Changes:

  • Introduce src/lib/esnext.core.d.ts defining Math.sumPrecise.
  • Reference esnext.core from src/lib/esnext.d.ts and add it to the default libs list in src/lib/libs.json.
  • Add a compile-check baseline file that currently captures a TS2726 error.

Reviewed changes

Copilot reviewed 2 out of 4 changed files in this pull request and generated 2 comments.

File Description
tests/baselines/reference/libCompileChecks.errors.txt Adds a baseline capturing a missing-lib compile error for esnext.core.
src/lib/libs.json Adds esnext.* libs to the default libraries list.
src/lib/esnext.d.ts References the new esnext.core lib from the esnext umbrella lib.
src/lib/esnext.core.d.ts Introduces the esnext.core lib surface (Math.sumPrecise).

Comment on lines +1 to +4
lib.esnext.d.ts(--,--): error TS2726: Cannot find lib definition for 'esnext.core'.


==== libCompileChecks.ts (0 errors) ====
Comment thread src/lib/libs.json Outdated
Comment on lines +103 to +105
"esnext.collection",
"esnext.core",
"esnext.date",
@tanushbhootra576

Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

@RyanCavanaugh

Copy link
Copy Markdown
Member

@tanushbhootra576 #63429 is already open, why did you open another PR with basically the same diff?

@tanushbhootra576

Copy link
Copy Markdown
Author

@RyanCavanaugh Ah, my apologies! I filtered the tracker for open 'Help Wanted' issues and completely missed that #63429 was already linked and addressing this. I'll close this duplicate right now to keep your review queue clean. Great to see this spec getting merged in!

@github-project-automation github-project-automation Bot moved this from Not started to Done in PR Backlog Jun 12, 2026
@tanushbhootra576 tanushbhootra576 deleted the fix/math-sum-precise branch June 12, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add type definition for Math.sumPrecise (ES2025 / TC39 proposal)

3 participants