Skip to content

feat(paper2video): group wrapped-line cues + card-aware ink-tighten spotlight - #25

Open
ArmandXiao wants to merge 1 commit into
mainfrom
feat/paper2video-spotlight-ink-tighten
Open

feat(paper2video): group wrapped-line cues + card-aware ink-tighten spotlight#25
ArmandXiao wants to merge 1 commit into
mainfrom
feat/paper2video-spotlight-ink-tighten

Conversation

@ArmandXiao

Copy link
Copy Markdown
Collaborator

Summary

The video spotlight previously drew the shape's raw declared box (PPTX off/ext or a semantic estimate), so it either dropped a wrapped title's second line or spotlighted a lot of empty leading/padding. This makes the spotlight track the intended logical unit — tightly for text, fully for cards — via two composed stages:

  1. Wrapped-line grouping (generate_visual_cues.py) — before emitting a cue, union same-group single-line title/tagline fragments into the whole wrapped run, so a cue that matched one line spotlights the whole title/tagline. Multi-line paragraph blocks are never merged, preserving the script's per-chunk progression. Guarded by VIDEO_CUE_GROUP_WRAPPED_LINES + geometry knobs (WRAP_X_EPS, WRAP_MIN_ASPECT, WRAP_GAP_FRAC).
  2. Card-aware ink-tighten (render_video.py) — shrink each spotlight box to the painted ink (glyphs) for transparent text so it hugs the content, but keep a filled card/panel whole via robust detection: page bg = the dominant colour over a coarse grid of the source slide (robust to a corner accent bar, unlike sampling the four corners), and the box is a card when most of its border ring hugs one fill colour (close_frac, which survives a thin accent bar on one edge) that differs from the page bg. Feather/dim + card thresholds are env-tunable (same defaults); best-effort — degrades to the declared box without Pillow/numpy or on low confidence.

Architecture: grouping decides WHAT unit to highlight (structure domain); ink-tighten decides HOW tightly + preserves filled cards (pixel domain); per-chunk progression is untouched.

Files changed

  • ResearchStudio-Reel/skills/paper2video/scripts/render_video.py (+112): new _ink_tighten_box() (letterbox-aware, card detection), VisualCue.no_ink_tighten override, env-tunable feather/dim + card thresholds, wired into encode_segment's spotlight loop.
  • ResearchStudio-Reel/skills/paper2video/scripts/generate_visual_cues.py (+91): new union_wrapped_line_cues() + helpers, called once per slide before appending cues.

Validation (new vs upstream-main render, identical deck+audio+cues)

  • Loose/text deck (2607.05394) — a 2-line tagline split across boxes + loose labels + filled takeaway card: 23/23 spotlight frames change, avg 5.08% pixels. Tagline now covers both lines tightly, filled cards stay fully lit (right padding no longer dimmed), loose labels hug their glyphs.
  • Card-heavy deck (2607.04438, 10-min, 38 cues) — already-tight boxes: 37/38 frames byte-identical. Card-aware correctly preserves all 8 filled cards (no "hole in the card" regression), 1 minor text tighten. Confirms this is a backward-compatible superset — it only changes a box when there is something loose to hug or a card to preserve.

Known follow-up (not in this PR)

VIDEO_SPOTLIGHT_FEATHER_PX alone is dominated by the ratio term (min(1920,1080) * 0.052 = 56), so setting only FEATHER_PX does not change the feather. Making FEATHER_PX authoritative (and picking a tighter default) is a small follow-up.

…potlight

Spotlight now composes two stages instead of drawing the raw declared box:

- generate_visual_cues.py: union same-group single-line title/tagline
  fragments into the whole wrapped unit before emitting the cue, so a cue
  that matched one line spotlights the whole title/tagline. Multi-line
  paragraph blocks are never merged, preserving the script's per-chunk
  progression. Gated by VIDEO_CUE_GROUP_WRAPPED_LINES + geometry env knobs.

- render_video.py: shrink each spotlight box to the painted ink (glyphs) for
  transparent text so it hugs the content, but keep a filled card/panel whole
  via robust detection (dominant grid page_bg + border-ring uniformity that
  survives an accent bar). Feather/dim + card thresholds are now env-tunable
  (same defaults); best-effort, degrades to the declared box without
  Pillow/numpy or on low confidence.

Net: the spotlight tracks the intended logical unit tightly (text) or fully
(cards) instead of the loose declared box. Backward-compatible superset.
@microsoft-github-policy-service

Copy link
Copy Markdown

@ArmandXiao please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant