Skip to content

[Main]-Incident 51000001072719 : [BC-IN][28.1] Wrong TDS amount is being reflected on the TDS Entries page while posting a Purchase Invoice against a foreign (NRI) vendor.#9201

Open
v-ajaztabrez wants to merge 1 commit into
microsoft:mainfrom
v-ajaztabrez:bugs/Bug-641470-Main-Wrong-TDS-amount-calculated-against-NRI-vendor
Open

Conversation

@v-ajaztabrez

@v-ajaztabrez v-ajaztabrez commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Bug 641470: Incident 51000001072719 : [BC-IN][28.1] Wrong TDS amount is being reflected on the TDS Entries page while posting a Purchase Invoice against a foreign (NRI) vendor.

[AB#641470]

Issue: When posting a Purchase Invoice for a foreign (NRI) vendor without a PAN number under a Concessional Code, the TDS amount on the TDS Entries page was shown in the vendor's foreign currency (e.g., USD/EUR) instead of LCY (INR), while the corresponding G/L Entry was correctly posted in LCY.

Cause: The tax-engine use case fee5dfff-0bc1-4246-ad90-6cb3dc44a451.json ("Non-Resident Vendor Invoice, no PAN, with Concessional Codes") was missing the Currency Code field mapping in its TDS Entry insert record. Because TDS Entry.OnInsert performs the FCY→LCY conversion only when Currency Code <> '', the entry was inserted with a blank currency code and the amounts were never converted, leaving them in foreign currency.

Solution: Added the missing Currency Code posting field (sourced from the Purchase Line) to the TDS Entry insert record in fee5dfff-0bc1-4246-ad90-6cb3dc44a451.json, matching the working NRI use cases (487c3669, 75222e87). This ensures the TDS Entry is inserted with the correct currency code, triggering the FCY→LCY conversion so the TDS amounts are stored in LCY.

@v-ajaztabrez v-ajaztabrez requested a review from a team July 7, 2026 21:52
@github-actions github-actions Bot added the From Fork Pull request is coming from a fork label Jul 7, 2026
@v-ajaztabrez v-ajaztabrez enabled auto-merge July 7, 2026 21:54
@github-actions github-actions Bot added the Linked Issue is linked to a Azure Boards work item label Jul 7, 2026
@github-actions github-actions Bot added this to the Version 29.0 milestone Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Copilot PR Review

Iteration 2 · Outcome: no-knowledge

Diff is limited to a single-line integer version bump in a codeunit dictionary registration and a matching data-only revision to a non-AL TDS use-case JSON resource. No changed AL constructs overlapped any performance, security, privacy, style, or UI knowledge domain; no upgrade/install codeunit, table schema, enum, or migration namespace was touched.

Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630

No findings were posted for this iteration.

Orchestrator pre-filter (13 file(s) excluded)

  • layer-disabled (knowledge) : 13 file(s)

Findings produced by the Copilot CLI agent against BCQuality at 822cae1b2771ac25f665f73369f69093bd4fd630. Reply 👎 on any inline comment to flag false positives.

@v-ajaztabrez

Copy link
Copy Markdown
Contributor Author

Closing it to requeue checks and tests.

auto-merge was automatically disabled July 8, 2026 04:31

Pull request was closed

@v-ajaztabrez v-ajaztabrez reopened this Jul 8, 2026
@v-ajaztabrez v-ajaztabrez enabled auto-merge July 8, 2026 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

From Fork Pull request is coming from a fork Linked Issue is linked to a Azure Boards work item

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant