[Main]-Incident 51000001072719 : [BC-IN][28.1] Wrong TDS amount is being reflected on the TDS Entries page while posting a Purchase Invoice against a foreign (NRI) vendor.#9201
Open
v-ajaztabrez wants to merge 1 commit into
Conversation
Contributor
Copilot PR ReviewIteration 2 · Outcome: no-knowledge
Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630 No findings were posted for this iteration. Orchestrator pre-filter (13 file(s) excluded)
Findings produced by the Copilot CLI agent against BCQuality at |
Contributor
Author
|
Closing it to requeue checks and tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 641470: Incident 51000001072719 : [BC-IN][28.1] Wrong TDS amount is being reflected on the TDS Entries page while posting a Purchase Invoice against a foreign (NRI) vendor.
[AB#641470]
Issue: When posting a Purchase Invoice for a foreign (NRI) vendor without a PAN number under a Concessional Code, the TDS amount on the TDS Entries page was shown in the vendor's foreign currency (e.g., USD/EUR) instead of LCY (INR), while the corresponding G/L Entry was correctly posted in LCY.
Cause: The tax-engine use case fee5dfff-0bc1-4246-ad90-6cb3dc44a451.json ("Non-Resident Vendor Invoice, no PAN, with Concessional Codes") was missing the Currency Code field mapping in its TDS Entry insert record. Because TDS Entry.OnInsert performs the FCY→LCY conversion only when Currency Code <> '', the entry was inserted with a blank currency code and the amounts were never converted, leaving them in foreign currency.
Solution: Added the missing Currency Code posting field (sourced from the Purchase Line) to the TDS Entry insert record in fee5dfff-0bc1-4246-ad90-6cb3dc44a451.json, matching the working NRI use cases (487c3669, 75222e87). This ensures the TDS Entry is inserted with the correct currency code, triggering the FCY→LCY conversion so the TDS amounts are stored in LCY.