Obsolete banking and payment functionality in FI BaseApp#9197
Draft
ventselartur wants to merge 1 commit into
Draft
Obsolete banking and payment functionality in FI BaseApp#9197ventselartur wants to merge 1 commit into
ventselartur wants to merge 1 commit into
Conversation
Ports NAV PR 246288 to BCApps. Delocalizes banking and payment functionality from the FI BaseApp to a separate Banking and Payments FI app by marking the affected fields, keys, controls and code paths obsolete (Pending 29.0 / removed schema 32.0) behind CLEAN29 / CLEANSCHEMA32 guards, gated at runtime by the new BankingAndPaymentsFI feature. - Add codeunit 32000003 "FI Banking Payment Feature" exposing IsEnabled() over the BankingAndPaymentsFI feature key. - Obsolete banking/payment fields on standard and local FI tables and wrap the related code, page controls, permission set entries, demo data and tests with #if not CLEAN29 / IsEnabled() guards. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Delocalizes banking and payment functionality from the FI BaseApp to a separate Banking and Payments FI app. The affected fields, keys, page controls, permission-set entries, code paths, demo data and tests are marked obsolete (
Pending29.0 / removed schema 32.0) behindCLEAN29/CLEANSCHEMA32guards, and gated at runtime by the newBankingAndPaymentsFIfeature.Changes
32000003 "FI Banking Payment Feature"exposingIsEnabled()over theBankingAndPaymentsFIfeature key.#if not CLEAN29/IsEnabled()guards.Fixes: AB#622873