Skip to content

Keep local microscaler-observability as a path dep; rewrite to git only in GitHub Actions#369

Draft
casibbald with Copilot wants to merge 5 commits into
mainfrom
copilot/switch-out-microscaler-observability
Draft

Keep local microscaler-observability as a path dep; rewrite to git only in GitHub Actions#369
casibbald with Copilot wants to merge 5 commits into
mainfrom
copilot/switch-out-microscaler-observability

Conversation

Copilot AI commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Local development expects microscaler-observability to come from the sibling checkout at ../microscaler-observability, but the previous change converted it to a git dependency globally. This change restores the local path dependency and moves the git switch into GitHub Actions so CI can rewrite the manifest at runtime.

  • Dependency resolution

    • Restore microscaler-observability in Cargo.toml to the local sibling path:
      microscaler-observability = { path = "../microscaler-observability" }
    • Update Cargo.lock to match the path-based local-dev state.
  • GitHub Actions runtime rewrite

    • Add a workflow step in ci.yml to rewrite the dependency before any Cargo commands run.
    • Add the same rewrite in docs.yml so doc builds do not depend on the sibling checkout existing on runners.
  • CI-only switch behavior

    • GitHub runners now patch Cargo.toml in-place to use the hosted repo:
      sed -i 's|microscaler-observability = { path = "../microscaler-observability" }|microscaler-observability = { git = "https://github.com/microscaler/microscaler-observability.git", branch = "main" }|' Cargo.toml
    • This preserves the existing local dev workflow while keeping CI self-contained.
  • Repo docs

    • Add a short llmwiki/log.md note documenting the local-vs-CI dependency policy for this repo.

Copilot AI changed the title fix(ci): checkout microscaler-observability sibling repo before Rust builds fix(deps): replace microscaler-observability path dep with git URL Jun 25, 2026
Copilot AI requested a review from casibbald June 25, 2026 06:25
Copilot AI changed the title fix(deps): replace microscaler-observability path dep with git URL Keep local microscaler-observability as a path dep; rewrite to git only in GitHub Actions Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants